[HttpKernel] Move duplicated logic from Esi/Ssi to an AbstractSurrogate #18833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b3835c to
fb6860c
Compare
1e8040d to
cd802cf
Compare
cd802cf to
e24b1bd
Compare
| throw $e; | ||
| } | ||
| } | ||
| // remove SSI/1.0 from the Surrogate-Control header |
Fabbot fixes Move duplicated logic from Esi/Ssi::process in AbstractSurrogate::removeFromControl Fabbot fixes Fix comment
e24b1bd to
c5dc50d
Compare
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jun 15, 2016
…AbstractSurrogate (chalasr) This PR was merged into the 3.2-dev branch. Discussion ---------- [HttpKernel] Move duplicated logic from Esi/Ssi to an AbstractSurrogate | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations?| no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- c5dc50d Move duplicated logic from Esi/Ssi to an AbstractSurrogate
| * @author Fabien Potencier <fabien@symfony.com> | ||
| * @author Robin Chalas <robin.chalas@gmail.com> | ||
| */ | ||
| abstract class AbstractSurrogate implements SurrogateInterface |
There was a problem hiding this comment.
this should be either marked as @internal or the PR is a new feature in contrast to the PR header (which means a use-case should be given).
There was a problem hiding this comment.
@Tobion I marked it as a new feature in the header (as made in the merge commit) & added a description.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the not-specific logic from the Esi/Ssi classes into an abstract class that they extend.
This class (
AbstractSurrogate) can be extended by any class implementing a Surrogate-Capability to the Request+Response instances, as Esi/Ssi do for ESI/SSI capabilities.