[Debug] More compact HTML #18841
Merged
[Debug] More compact HTML #18841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 We intend to revamp this page soon ... but this looks like a quick win while we do that. |
|
Thank you @c960657. |
fabpot
added a commit
that referenced
this pull request
May 24, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [Debug] More compact HTML | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This patch makes the HTML output for exception stack traces slightly more compact. This makes the stack trace a bit more readable when inspecting the HTML source, e.g. when using cURL. 1. Vendor-specific prefixes for border-radius are removed. They are not relevant [in any modern browser](http://caniuse.com/border-radius). 2. The ondblclick is now added only once and relies on event bubbling rather than being added to every `<li>` in the stack trace. 3. Single quotes are not escaped. Escaping single quotes is only required for values enclosed in single quoted HTML attributes - all our attributes are double-quoted. Commits ------- 9613b75 [Debug] More compact HTML
|
Any chance this could be merged into a release branch? It does not affect BC. (I can see that the policy (or the description of the policy, at least) on which branch to submit against has been updated recently. In the future I will submit PRs for such changes against the release branch) |
|
You should probably refer to http://symfony.com/doc/current/contributing/code/maintenance.html instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the HTML output for exception stack traces slightly more compact. This makes the stack trace a bit more readable when inspecting the HTML source, e.g. when using cURL.
<li>in the stack trace.