Skip to content

[Console] StyleInterface: Add missing comment() #18888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Console] StyleInterface: Add missing comment() #18888

wants to merge 1 commit into from

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented May 26, 2016

Q A
Branch? 2.8
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@ogizanagi
Copy link
Contributor

ogizanagi commented May 26, 2016 •
edited
Loading

@chalasr : IIRC, it wasn't added on purpose actually (it was too late on 2.8, as the interface already existed. Also this interface is subject to controversy. See #15964 (comment))

@chalasr
Copy link
Member Author

chalasr commented May 26, 2016

I didn't see that so thank's to pointing it to me, I'll quietly close this.

@chalasr chalasr closed this May 26, 2016
@chalasr chalasr deleted the patch_sfstyle_api_comment branch May 26, 2016 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Console Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @ogizanagi @carsonbot