Fixed singular of committee #18911
Fixed singular of committee #18911
Conversation
| @@ -211,8 +210,13 @@ public static function singularify($plural) | |||
| } | |||
| } | |||
|
|
|||
| $irregularNouns = array( | |||
There was a problem hiding this comment.
would be better as a private static var
There was a problem hiding this comment.
I had it like that prior to the PR but since those are irregular nouns in that context I have moved that into the function.
There was a problem hiding this comment.
Inline arrays are can't benefit from some opcache optims until php7. A private static would fix that
There was a problem hiding this comment.
Shall I update it accordingly? I prefered the logic reason.
There was a problem hiding this comment.
@nicolas-grekas Shall I refactor it? I would like to get this merged.
|
@nicolas-grekas Updated |
|
@nicolas-grekas Both PR's are updated |
|
Just added support for |
|
Thank you @peterrehm. |
This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes #18911). Discussion ---------- Fixed singular of committee | Q | A | ------------- | --- | Branch? | 2.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18872, #18748 | License | MIT | Doc PR | - In addition to PR #18909. Commits ------- 5661d52 Fixed singular of committee
In addition to PR #18909.