Skip to content

Added missing APCU CacheProvider of doctrine/cache 1.6.x #18974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2016

Conversation

fncmedia
Copy link
Contributor

@fncmedia fncmedia commented Jun 6, 2016

Q A
Branch? 3.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets yes
License MIT
Doc PR reference to the documentation PR, if any

@nicolas-grekas
Copy link
Member

👍
Status: reviewed

@dunglas
Copy link
Member

dunglas commented Jun 8, 2016

👍

@fabpot
Copy link
Member

fabpot commented Jun 8, 2016

Thank you @fncmedia.

@fabpot fabpot merged commit a104c39 into symfony:3.1 Jun 8, 2016
fabpot added a commit that referenced this pull request Jun 8, 2016
…Carsten Eilers)

This PR was merged into the 3.1 branch.

Discussion
----------

Added missing APCU CacheProvider of doctrine/cache 1.6.x

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | yes
| License       | MIT
| Doc PR        | reference to the documentation PR, if any

Commits
-------

a104c39 Added APCU CacheProvider of doctrine/cache 1.6.x
@fabpot fabpot mentioned this pull request Jun 15, 2016
@dextervip
Copy link

Is it not going to be supported in 2.8?

@xabbuh
Copy link
Member

xabbuh commented Jun 15, 2016

@dextervip No, we never backport features to already released minor versions.

@dunglas
Copy link
Member

dunglas commented Jun 16, 2016

@xabbuh this one is really annoying because it prevents using Symfony 2 on PHP 7 with decent performances. The compatibility layer between APC and APCu has been disabled by default on APCu for PHP 7 and requires to recompile the extension to enable it.

@dextervip
Copy link

That's my issue. I've upgraded to PHP 7 with sf2.8 but I am unable to use apcu cache now. And I can't upgrade to sf3.x right now. Any workarounds for this?

@teohhanhui
Copy link
Contributor

teohhanhui commented Jun 17, 2016

What is this used for, actually?

Because before this I can already do:

# app/config/config_prod.yml
doctrine:
    orm:
        metadata_cache_driver: 'apcu'
        result_cache_driver: 'apcu'
        query_cache_driver: 'apcu'

Or is it non-functional? 😛 (But I thought it should throw \InvalidArgumentException if that's the case...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants