[HttpKernel] Add convenient method ArgumentResolver:: getDefaultArgumentValueResolvers #19011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC, making the service immutable was done on purpose |
|
it make make sense to have a static method returning the array of builtin value resolvers though, to make it easier to register them when adding additional ones |
6d6018e to
6fdfc92
Compare
|
I've updated the PR according to @stof comment |
|
The static method is nice, adds a good DX when used outside of the full framework. |
|
Thank you @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Jun 10, 2016
…getDefaultArgumentValueResolvers (romainneutron) This PR was merged into the 3.2-dev branch. Discussion ---------- [HttpKernel] Add convenient method ArgumentResolver:: getDefaultArgumentValueResolvers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A I realized while implementing my own `ArgumentValueResolver` that registering a new one is not easy, you have to give the whole list of resolver instead of pushing your one in the stack. Commits ------- 6fdfc92 [HttpKernel] Add convenient method ArgumentResolver::addArgumentValueResolver
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized while implementing my own
ArgumentValueResolverthat registering a new one is not easy, you have to give the whole list of resolver instead of pushing your one in the stack.