Skip to content

[Cache] Add tags based invalidation + TagAwareRedisAdapter #19047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2016
Merged

[Cache] Add tags based invalidation + TagAwareRedisAdapter #19047

merged 1 commit into from
Jun 17, 2016

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jun 14, 2016 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #18646
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas changed the title Cache tag store [Cache] Add tags based invalidation + RedisTaggedAdapter Jun 14, 2016
@nicolas-grekas nicolas-grekas force-pushed the cache-tag-store branch 3 times, most recently from 40f6846 to 8cc7f94 Compare June 14, 2016 06:36
@nicolas-grekas nicolas-grekas force-pushed the cache-tag-store branch 3 times, most recently from ba4e17c to c2fb3b0 Compare June 14, 2016 11:34
@nicolas-grekas
Copy link
Member Author

Rebased, RFR

@nicolas-grekas nicolas-grekas force-pushed the cache-tag-store branch 7 times, most recently from a37fd52 to b2c84f0 Compare June 17, 2016 15:26
fabpot
fabpot reviewed Jun 17, 2016
View reviewed changes
src/Symfony/Component/Cache/README.md
@@ -1,7 +1,7 @@
Symfony PSR-6 implementation for caching
========================================

This component provides a strict [PSR-6](http://www.php-fig.org/psr/psr-6/)
This component provides a extended [PSR-6](http://www.php-fig.org/psr/psr-6/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an extended

@nicolas-grekas nicolas-grekas force-pushed the cache-tag-store branch 2 times, most recently from 229e33e to 15c2bea Compare June 17, 2016 15:38
@nicolas-grekas nicolas-grekas changed the title [Cache] Add tags based invalidation + RedisTaggedAdapter [Cache] Add tags based invalidation + TagAwareRedisAdapter Jun 17, 2016
@fabpot
Copy link
Member

fabpot commented Jun 17, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 19764af into symfony:master Jun 17, 2016
fabpot added a commit that referenced this pull request Jun 17, 2016
@fabpot
feature #19047 [Cache] Add tags based invalidation + TagAwareRedisAda…
40f4c57 
…pter (nicolas-grekas)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[Cache] Add tags based invalidation + TagAwareRedisAdapter

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #18646
| License       | MIT
| Doc PR        | -

Commits
-------

19764af [Cache] Add tags based invalidation + TagAwareRedisAdapter
@nicolas-grekas nicolas-grekas deleted the cache-tag-store branch June 17, 2016 17:47
This was referenced Jun 20, 2016
Closed
Closed
@nicolas-grekas nicolas-grekas mentioned this pull request Aug 4, 2016
Merged
nicolas-grekas added a commit that referenced this pull request Aug 7, 2016
@nicolas-grekas
feature #19524 [Cache] Add generic TagAwareAdapter wrapper (replaces …
66b84b2 
…TagAwareRedisAdapter) (nicolas-grekas)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[Cache] Add generic TagAwareAdapter wrapper (replaces TagAwareRedisAdapter)

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#6858

This PR replaces TagAwareRedisAdapter introduced in #19047 by a generic `TagAwareAdapter` that works with any two adapters.

Commits
-------

288308b [Cache] Add generic TagAwareAdapter wrapper (replaces TagAwareRedisAdapter)
@fabpot fabpot mentioned this pull request Oct 27, 2016
Merged
@aik099
Copy link

aik099 commented Sep 20, 2017

@nicolas-grekas ,

  1. I see, that TagAwareRedisAdapter was added here, but I don't see it anymore in Symfony 3.3.9. Was it removed?
  2. How do I create taggable cache adapter from file (for tag storage) and memcached (for data storage) adapters and then set it via framework.cache.app config option in app/config/config.yml?

Thanks.

@xabbuh
Copy link
Member

xabbuh commented Sep 20, 2017

@aik099 The TagAwareRedisAdapter was replaced by a generic TagAwareAdapter in #19524.

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Sep 20, 2017 •
edited
Loading

@aik099 TagAwareRedisAdapter has never been released. Use TagAwareAdapter instead. For you other question, I invite you to use a support channel (we use github for dev, not support, see http://symfony.com/support)

@aik099
Copy link

aik099 commented Sep 20, 2017 •
edited
Loading

I've tried #support channel on Slack, but apparently nobody in there is using TagAwareAdapter and therefore we weren't able to get actually working solution :(

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Cache Feature Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @fabpot @aik099 @xabbuh @javiereguiluz @carsonbot