[Process] Allow inheriting env vars instead of replacing them #19053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jun 14, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18796 |
| License | MIT |
| Doc PR | - |
|
|
||
| if (!is_resource($this->process)) { | ||
| echo $commandline; |
79963fe to
5c6248b
Compare
|
Comments addressed, all green :) |
| } | ||
| $env = '\\' === DIRECTORY_SEPARATOR ? '(SET %s)&&' : 'export %s;'; | ||
| foreach ($this->env as $k => $v) { | ||
| $envline .= sprintf($env, ProcessUtils::escapeArgument("$k=$v")); |
There was a problem hiding this comment.
Don't we need one space after a value if it is followed by another key?
Never mind, you use one export per environment variable.
| * | ||
| * @param bool $inheritEnv | ||
| * | ||
| * @return ProcessBuilder |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 15, 2016
…ng them (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [Process] Allow inheriting env vars instead of replacing them | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18796 | License | MIT | Doc PR | - Commits ------- 524508c [Process] Allow merging env vars instead of replacing them
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.