[Console] SymfonyQuestionHelper with multi-select choice failes with multiple defaults #19099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and CHANGELOG (zdenekdrahos) This PR was squashed before being merged into the 2.8 branch (closes symfony#19083). Discussion ---------- Mention generating absolute urls in UPGRADE files and CHANGELOG | Q | A | ------------- | --- | Branch? | 2.8+ | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#19058 | License | MIT | Doc PR | - Commits ------- 5f506d9 Mention generating absolute urls in UPGRADE files and CHANGELOG
|
Crap, wrong branch 💀 and forgot to commit the actual changes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use the SymfonyStyle with a multi-choice question and multiple defaults.
You get an notice because the key is used as-is
0,1instead of splitting the value.This pull-request changes the SymfonyQuestionHelper to checks if the Choice is a multi-choice
and displays the selected values correctly
[blue, yellow].Note: Tests are missing, but both the SymfonyStyle and SymfonyQuestionHelper classes
have almost no tests. Making it really hard 😇 hopefully #19097 will make this easier 👍