Skip to content

[Console] SymfonyQuestionHelper with multi-select choice failes with multiple defaults #19099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Console] SymfonyQuestionHelper with multi-select choice failes with multiple defaults #19099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f506d9
Mention generating absolute urls in UPGRADE files and CHANGELOG
zdenekdrahos Jun 17, 2016
14d48a1
minor #19083 Mention generating absolute urls in UPGRADE files and CH…
fabpot Jun 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions UPGRADE-2.8.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,3 +630,31 @@ HttpFoundation
```php
$request->query->get('foo')[bar];
```

Routing
-------

* Deprecated the hardcoded value for the `$referenceType` argument of the `UrlGeneratorInterface::generate` method.
Use the constants defined in the `UrlGeneratorInterface` instead.

Before:

```php
// url generated in controller
$this->generateUrl('blog_show', array('slug' => 'my-blog-post'), true);

// url generated in @router service
$router->generate('blog_show', array('slug' => 'my-blog-post'), true);
```

After:

```php
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

// url generated in controller
$this->generateUrl('blog_show', array('slug' => 'my-blog-post'), UrlGeneratorInterface::ABSOLUTE_URL);

// url generated in @router service
$router->generate('blog_show', array('slug' => 'my-blog-post'), UrlGeneratorInterface::ABSOLUTE_URL);
```
24 changes: 24 additions & 0 deletions UPGRADE-3.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,30 @@ UPGRADE FROM 2.x to 3.0
* The `getMatcherDumperInstance()` and `getGeneratorDumperInstance()` methods in the
`Symfony\Component\Routing\Router` have been changed from `public` to `protected`.

* Use the constants defined in the UrlGeneratorInterface for the $referenceType argument of the UrlGeneratorInterface::generate method.

Before:

```php
// url generated in controller
$this->generateUrl('blog_show', array('slug' => 'my-blog-post'), true);

// url generated in @router service
$router->generate('blog_show', array('slug' => 'my-blog-post'), true);
```

After:

```php
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

// url generated in controller
$this->generateUrl('blog_show', array('slug' => 'my-blog-post'), UrlGeneratorInterface::ABSOLUTE_URL);

// url generated in @router service
$router->generate('blog_show', array('slug' => 'my-blog-post'), UrlGeneratorInterface::ABSOLUTE_URL);
```

### Security

* The `Resources/` directory was moved to `Core/Resources/`
Expand Down
16 changes: 16 additions & 0 deletions src/Symfony/Component/Routing/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,22 @@ CHANGELOG
* allowed specifying a directory to recursively load all routing configuration files it contains
* Added ObjectRouteLoader and ServiceRouteLoader that allow routes to be loaded
by calling a method on an object/service.
* [DEPRECATION] Deprecated the hardcoded value for the `$referenceType` argument of the `UrlGeneratorInterface::generate` method.
Use the constants defined in the `UrlGeneratorInterface` instead.

Before:

```php
$router->generate('blog_show', array('slug' => 'my-blog-post'), true);
```

After:

```php
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;

$router->generate('blog_show', array('slug' => 'my-blog-post'), UrlGeneratorInterface::ABSOLUTE_URL);
```

2.5.0
-----
Expand Down