Skip to content

[TwigBridge] Foundation 6 form layout integration #19109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

phan7om
Copy link

@phan7om phan7om commented Jun 19, 2016

Q A
Branch? "master" for new features
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT
Doc PR http://symfony.com/doc/current/cookbook/form/form_customization.html#what-are-form-themes

This feature inspired by Foundation 5 template. Improvements are based on http://foundation.zurb.com/sites/docs/abide.html

@dunglas
Copy link
Member

dunglas commented Jun 21, 2016

Integrating Foundation in core has already been refused: #12587

Maybe should you create a community bundle for that and maybe can we mention it in the Symfony doc.

@dunglas
Copy link
Member

dunglas commented Jun 21, 2016

My bad, it was accepted. So why not the new version.

@jrattue
Copy link

jrattue commented Jul 11, 2016

@phan7om As foundation is mobile first, should the classes be "small-12" rather than "large-12"?

@phan7om
Copy link
Author

phan7om commented Jul 21, 2016

@Rattler3 for the only one class it's doesn't matter large-12 or small-12. it's the same.
Many combined classes usage needed to organize the look of page in small or large screen properly.
It this case large-12 or small-12 mean full horizontal row of content

@nicolas-grekas nicolas-grekas added this to the 3.x milestone Dec 6, 2016
@fabpot
Copy link
Member

fabpot commented Feb 19, 2017

What's the status of this PR?

@fabpot
Copy link
Member

fabpot commented Mar 5, 2017

Closing as there is no more feedback. Feel free to reopen.

@fabpot fabpot closed this Mar 5, 2017
@nicolas-grekas nicolas-grekas modified the milestones: 3.x, 3.3 Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants