Response headers fix #19143
Merged
Response headers fix #19143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e775f3 to
429034f
Compare
| @@ -281,7 +281,7 @@ public function makeDisposition($disposition, $filename, $filenameFallback = '') | |||
| protected function computeCacheControlValue() | |||
| { | |||
| if (!$this->cacheControl && !$this->has('ETag') && !$this->has('Last-Modified') && !$this->has('Expires')) { | |||
| return 'no-cache'; | |||
| return 'no-cache, private'; | |||
There was a problem hiding this comment.
Adding private is what we are doing by default line 299 in the same situation.
429034f to
66afa01
Compare
| $bag1 = new ResponseHeaderBag($headers); | ||
| $bag2 = new ResponseHeaderBag($bag1->allPreserveCase()); | ||
| //print_r($bag1->allPreserveCase()); | ||
| //print_r($bag2->allPreserveCase()); |
There was a problem hiding this comment.
These print_r() weren't removed.
|
👍 (on 3.2 or as bug fix either) |
|
👍 |
fabpot
added a commit
that referenced
this pull request
Jun 23, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- Response headers fix | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | yes/no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16171, #16307 | License | MIT | Doc PR | n/a To fix the inconsistency mentioned in #16171, I think the "best" solution would be to add `private` when cache-control is not set, which was the intention but was forgotten. I propose to make the fix in 3.2 only as it might be a BC break. Commits ------- 66afa01 [HttpFoundation] added private by default when setting Cache-Control to no-cache
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the inconsistency mentioned in #16171, I think the "best" solution would be to add
privatewhen cache-control is not set, which was the intention but was forgotten.I propose to make the fix in 3.2 only as it might be a BC break.