[Routing] rename boolean and integer to bool and int #19157
Conversation
|
I would stick to full names here. We already use |
|
I also prefer the full names. |
|
👍 I agree with @xabbuh here. |
|
👍 since I tend to agree for the short version also because of PHP types |
| <xsd:element name="boolean" nillable="true" type="map-boolean-entry" /> | ||
| <xsd:element name="integer" nillable="true" type="map-integer-entry" /> | ||
| <xsd:element name="bool" nillable="true" type="map-bool-entry" /> | ||
| <xsd:element name="int" nillable="true" type="map-integer-entry" /> |
There was a problem hiding this comment.
shouldn't it be renamed to map-int-entry as well?
There was a problem hiding this comment.
If we agree on renaming the types, we can do that here too (even if these are internal details that are not exposed to the end user).
|
Will this is not break for people that are already using this? It seems the XSD is updated, but no longer supports the other tags. |
|
@sstok if you follow the linked PR you'll see that this feature was just merged before. |
|
Hihi 😄 I looked at the initial date, not the date of the merge 😊 I'm 👍 on the full names, it's also what is used in the DependencyInjection XML schema. |
|
So, there is no consensus. What do we do? I don't care that much, so this PR is 👍 for me. |
|
@xabbuh Can you finish this one so that we can merge it? |
|
@fabpot done |
|
Thank you @xabbuh. |
…bbuh) This PR was merged into the 3.2-dev branch. Discussion ---------- [Routing] rename boolean and integer to bool and int | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11394 (comment) | License | MIT | Doc PR | This addresses @Tobion's comment in #11394 (comment). @symfony/deciders What do you think? Should we change the element names to how we use the types in PHP code or should we stick with XML element names that rather match the types as defined by the XML schema? Commits ------- 808dcc8 rename boolean and integer to bool and int
This addresses @Tobion's comment in #11394 (comment).
@symfony/deciders What do you think? Should we change the element names to how we use the types in PHP code or should we stick with XML element names that rather match the types as defined by the XML schema?