[Form] fixed bug - name in ButtonBuilder #19306
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| /** | ||
| * @return array | ||
| */ |
There was a problem hiding this comment.
There's no need for the docblocks in tests.
|
@xabbuh |
|
👍 |
|
Thank you @cheprasov. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2016
This PR was squashed before being merged into the 2.7 branch (closes #19306). Discussion ---------- [Form] fixed bug - name in ButtonBuilder | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - **Bug:** For any scalar of name, expression `empty($name) && 0 != $name` is never true, and as result - empty string ('') is allowed. **Examples:** ```php $name = ''; var_dump(empty($name) && 0 != $name); // false $name = '0'; var_dump(empty($name) && 0 != $name); // false $name = null; var_dump(empty($name) && 0 != $name); // false $name = false; var_dump(empty($name) && 0 != $name); // false $name = 0; var_dump(empty($name) && 0 != $name); // false ``` Commits ------- f507023 [Form] fixed bug - name in ButtonBuilder
This was referenced Jul 30, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
For any scalar of name, expression
empty($name) && 0 != $nameis never true,and as result - empty string ('') is allowed.
Examples: