[Validator] Added additional MasterCard range to the CardSchemeValidator #19316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From October 2016 MasterCard will introduce a new card range, 222100 through 272099. See: https://www.mctestcards.com/ (click the help in top right) Implements unit tests and validation for this new card range.
| @@ -102,6 +102,12 @@ public function getValidNumbers() | |||
| array('MAESTRO', '6594371785970435599'), | |||
| array('MASTERCARD', '5555555555554444'), | |||
| array('MASTERCARD', '5105105105105100'), | |||
| array('MASTERCARD', '2221005555554444'), | |||
| array('MASTERCARD', '2230000000000000'), | |||
| array('MASTERCARD', '2300000000000000'), | |||
There was a problem hiding this comment.
If we are testing 23xxx, 26xxx and 27xxx maybe we should also test the missing 24xxx and 25xxx to avoid future regressions (these regexps are a bit tricky).
There was a problem hiding this comment.
The reason for testing 23xxx and 26xxx is beceause they are both in the range where only the 2 first digits need checking.
Therefor i feel that testing 24xxx and 25xxx is redundant, but i can add them if needed ?
|
👍 The linked resource clearly shows that we should merge this as soon as possible. Thanks @dvaeversted. |
|
Thank you @dvaeversted. |
fabpot
added a commit
that referenced
this pull request
Jul 8, 2016
…chemeValidator (Dennis Væversted) This PR was merged into the 2.7 branch. Discussion ---------- [Validator] Added additional MasterCard range to the CardSchemeValidator From October 2016 MasterCard will introduce a new card range, 222100 through 272099. See: https://www.mctestcards.com/ (click the help in top right) This implements the additional regex for validation to succeed, and some additional unit tests for this new range. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 4d68f56 [Validator] Added additional MasterCard range to the CardSchemeValidator
This was referenced Jul 30, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From October 2016 MasterCard will introduce a new card range, 222100 through 272099.
See: https://www.mctestcards.com/ (click the help in top right)
This implements the additional regex for validation to succeed, and some additional unit tests for this new range.