Skip to content

[HttpFoundation] Use empty instead of count in RequestMatcher #19320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HttpFoundation] Use empty instead of count in RequestMatcher #19320

wants to merge 1 commit into from

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jul 9, 2016

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Miro optimization...

@stloyd
Copy link
Contributor

stloyd commented Jul 9, 2016

-1 as this 'micro' optimization is so small that you never notice it in real life usage IMO.

@fabpot
Copy link
Member

fabpot commented Jul 9, 2016

I'm also -1 as the current expression is very clear on what we check for. The semantic of empty is very blurry to say the least.

@dunglas
Copy link
Member Author

dunglas commented Jul 9, 2016

Fair enough

@dunglas dunglas closed this Jul 9, 2016
@dunglas dunglas deleted the optim_request_matcher branch July 9, 2016 10:05
@xabbuh xabbuh mentioned this pull request Jul 10, 2016
Closed
@chalasr chalasr mentioned this pull request Aug 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HttpFoundation Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunglas @stloyd @fabpot @carsonbot