[HttpFoundation] Add OPTIONS and TRACE to the list of safe methods #19321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
b7a24e2 to
85253e5
Compare
| public function methodProvider() | ||
| { | ||
| return array( | ||
| array(Request::METHOD_HEAD, true), |
There was a problem hiding this comment.
to be consistent with comments on other PRs, shouldn't we use plain strings here?
|
Comments fixed. |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Jul 10, 2016
… methods (dunglas) This PR was squashed before being merged into the 2.7 branch (closes #19321). Discussion ---------- [HttpFoundation] Add OPTIONS and TRACE to the list of safe methods | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a According to [RFC 7231](https://tools.ietf.org/html/rfc7231#section-8.1.3) `OPTIONS` and `TRACE` are safe methods. Commits ------- 1404607 [HttpFoundation] Add OPTIONS and TRACE to the list of safe methods
This was referenced Jul 30, 2016
Merged
Merged
Merged
Merged
|
The reasoning is RFC conformance. OPTIONS and TRACE are safe methods according to the specs. |
|
The relevant quote of RFC 7231: Of the request methods defined by this specification, the GET, HEAD, |
fabpot
added a commit
that referenced
this pull request
Oct 14, 2016
…e (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] no 304 response if method is not cacheable | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Since #19321 OPTIONS and TRACE are considered safe methods. But both methods should not lead to "304 Not modified" responses. Commits ------- 3d6b450 no 304 response if method is not cacheable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 7231
OPTIONSandTRACEare safe methods.