[Security] Fix the retrieval of the last username when using forwarding #19334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return $request->attributes->get(Security::LAST_USERNAME); | ||
| } | ||
|
|
||
| $session = $request->getSession(); | ||
|
|
||
| return null === $session ? '' : $session->get(Security::LAST_USERNAME); |
There was a problem hiding this comment.
Here, If session does not store Security::LAST_USERNAME then?
There was a problem hiding this comment.
I don't understand what you mean
There was a problem hiding this comment.
If $session have not contain "Security::LAST_USERNAME" in this case it should be null.
There was a problem hiding this comment.
$session->get() already return null if the key is not set.
|
Thank you @stof. |
fabpot
added a commit
that referenced
this pull request
Jul 13, 2016
…ng forwarding (stof) This PR was merged into the 2.7 branch. Discussion ---------- [Security] Fix the retrieval of the last username when using forwarding | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a When using forwarding to render the login page (which is not the default), the info are stored in the subrequest attributes rather than the session. ``getLastAuthenticationError`` was handling this properly but ``getLastUsername`` was not checking the attributes. This fixes it by checking the attributes (I'm checking them before the session, to be consistent with ``getLastAuthenticationError``) Commits ------- e041365 Fix the retrieval of the last username when using forwarding
This was referenced Jul 30, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using forwarding to render the login page (which is not the default), the info are stored in the subrequest attributes rather than the session.
getLastAuthenticationErrorwas handling this properly butgetLastUsernamewas not checking the attributes.This fixes it by checking the attributes (I'm checking them before the session, to be consistent with
getLastAuthenticationError)