Added class existence check if is_subclass_of() fails in compiler passes #19342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!is_subclass_of($class, $interface)) { | ||
| if (!class_exists($class, true)) { |
There was a problem hiding this comment.
true should be false: autoloading already happened the line before
|
@nicolas-grekas , i updated a code according your notes. |
|
👍 |
| if (!is_subclass_of($class, $interface)) { | ||
| if (!class_exists($class, false)) { | ||
| throw new \InvalidArgumentException(sprintf('Class "%s" used for service "%s" can not be found.', $class, $id)); |
There was a problem hiding this comment.
"cannot" instead of "can not" (same below)
|
@xabbuh , updated |
|
👍 |
|
Thank you @SCIF. |
fabpot
added a commit
that referenced
this pull request
Jul 18, 2016
…ompiler passes (SCIF) This PR was merged into the 2.8 branch. Discussion ---------- Added class existence check if is_subclass_of() fails in compiler passes | Q | A | ------------- | --- | Branch? | 2.8-3.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - If you create an event subscriber and make typo in file name it will cause next error: ``` [InvalidArgumentException] Service "event.notification_subscriber" must implement interface "Symfony\Component\EventDispatcher\EventSubscriberInterface". ``` That's because of `is_subclass_of()` fails on class absentee. I made error message more clear. Commits ------- 72db6e7 Added class existence check if is_subclass_of() fails in compiler passes
|
Should not this be back ported on the 2.7 branch? |
This was referenced Jul 30, 2016
Merged
Merged
Merged
|
@fabpot , is there any chance to merge that PR to 2.7? |
|
@SCIF please openq new PR |
|
@nicolas-grekas , will do, thanks! |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 9, 2016
…ompiler passes (SCIF) This PR was merged into the 2.7 branch. Discussion ---------- Added class existence check if is_subclass_of() fails in compiler passes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | comma-separated list of tickets fixed by the PR, if any | License | MIT | Doc PR | no Backport of #19342 to 2.7 branch Commits ------- 77adea7 Added class existence check if is_subclass_of() fails in compiler passes
nicolas-grekas
added a commit
that referenced
this pull request
Sep 6, 2016
…lass_of (chalasr) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Check for class existence before is_subclass_of | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Same as #19342 Commits ------- 8a9e0f5 [FrameworkBundle] Check for class existence before is_subclass_of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create an event subscriber and make typo in file name it will cause next error:
That's because of
is_subclass_of()fails on class absentee. I made error message more clear.