Fix the DBAL session handler version check for Postgresql #19369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@symfony/deciders anyone for the second review ? |
| $params = $this->con->getParams(); | ||
|
|
||
| if (isset($params['serverVersion'])) { | ||
| return $params['serverVersion']; // Explicit platform version requested (supersedes auto-detection), so we respect it. |
There was a problem hiding this comment.
Nitpicking: these long comments on the side of the code are a bit "strange" and, if I recall it correctly, not frequently used in Symfony. We usually put them just above the commented code.
|
👍 |
|
Thank you @stof. |
fabpot
added a commit
that referenced
this pull request
Jul 18, 2016
…(stof) This PR was merged into the 2.7 branch. Discussion ---------- Fix the DBAL session handler version check for Postgresql | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | n/a | License | MIT | Doc PR | n/a #19048 broken the DBAL session handler when using Postgresql by using method which does not exist on the main DBAL Connection class. Commits ------- e98c584 Fix the DBAL session handler version check for Postgresql
This was referenced Jul 30, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19048 broken the DBAL session handler when using Postgresql by using method which does not exist on the main DBAL Connection class.