Fix PHP 7.1 related failures #19384
Merged
Fix PHP 7.1 related failures #19384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to add 7.1 to the travis matrix then? |
e27cdc2 to
f8abf30
Compare
| @@ -19,7 +19,7 @@ | |||
| "php": ">=5.3.9" | |||
| }, | |||
| "require-dev": { | |||
| "symfony/yaml": "~2.1", | |||
| "symfony/yaml": "~2.3.42|~2.7.14|~2.8.7|~3.0.7|~3.1.1|~3.2", | |||
There was a problem hiding this comment.
#18861 required on PHP 7.1
| @@ -19,7 +19,7 @@ | |||
| "php": ">=5.3.9" | |||
| }, | |||
| "require-dev": { | |||
| "symfony/yaml": "~2.1", | |||
| "symfony/yaml": "~2.3.42|~2.7.14|~2.8.7", | |||
There was a problem hiding this comment.
should be ~2.8.7|~3.0.7|~3.1.1|~3.2 when merging in 3.0
|
Green, with php7.1 included in the test matrix |
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 19, 2016
This PR was merged into the 2.7 branch. Discussion ---------- Fix PHP 7.1 related failures | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - PHP 7.1 triggers notices on previously silent implicit type changes. Commits ------- 07467ed Fix PHP 7.1 related failures
This was referenced Jul 30, 2016
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.1 triggers notices on previously silent implicit type changes.