[Config] Extra tests for Config component #19399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zomberg
commented
Jul 21, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
| { | ||
| $builder = $this->getTestBuilder(); | ||
|
|
||
| $reflection = new \ReflectionProperty($builder, 'ifPart'); |
There was a problem hiding this comment.
Why do you need reflection here?
There was a problem hiding this comment.
Thanks. You are right. I didn't notice that this is public property. I fixed it.
|
👍 Status: reviewed @zomberg thanks for adding these missing tests! |
| $this->assertEquals(array('enabled' => false), $this->getField($node, 'falseEquivalent')); | ||
| $this->assertEquals(array('enabled' => true), $this->getField($node, 'trueEquivalent')); | ||
| $this->assertEquals(array('enabled' => true), $this->getField($node, 'nullEquivalent')); | ||
| $this->assertEquals(array('enabled' => true), $this->getField($node, 'nullEquivalent')); |
There was a problem hiding this comment.
@nicolas-grekas, done.
|
👍 with minor comment |
|
Thank you @zomberg. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 26, 2016
This PR was squashed before being merged into the 2.7 branch (closes #19399). Discussion ---------- [Config] Extra tests for Config component | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- d0f4434 [Config] Extra tests for Config component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.