Fixed bugs in names of classes and methods. #19405
Conversation
|
After fixing CS suggestion from fabbot.io I got new error. $instance->setBar(($this->get('foo')->foo().(($this->hasParameter('foo')) ? ($this->getParameter('foo')) : ('default'))));Code generated by PhpDumper: $instance->setBar(($this->get("foo")->foo() . (($this->hasParameter("foo")) ? ($this->getParameter("foo")) : ("default"))));I renamed 'hasparameter' -> 'hasParameter' and get CS notification from fabbot.io - remove space and change type of quotes. So PhpDumper generates code which cannot get CS verification by fabbot.io. I see 3 ways:
I think first is the best. What do you think the best way solve this problem? |
|
you should ignore CS changes asked by fabbot when they are about fixture files (I thought fabbot was ignoring these files, but it seems it does not) |
|
Thanks, @stof. Reverted CS fixes for fixture files. |
|
👍 Status: reviewed @zomberg thanks for these fixes. I wasn't aware about how many of these errors were on the code! |
| @@ -38,8 +38,8 @@ private function addSessionTable($tableName) | |||
| { | |||
| $table = $this->createTable($tableName); | |||
| $table->addColumn('sess_id', 'string'); | |||
| $table->addColumn('sess_data', 'text')->setNotNull(true); | |||
| $table->addColumn('sess_time', 'integer')->setNotNull(true)->setUnsigned(true); | |||
| $table->addColumn('sess_data', 'text')->setNotnull(true); | |||
There was a problem hiding this comment.
I'd rather change the method name here, WDYT?
There was a problem hiding this comment.
hum ok, it's in doctrine, not our code... then I prefer our way :)
There was a problem hiding this comment.
For me Symfony way is better too. But I think that we must use it as in declaration.
There was a problem hiding this comment.
We must not, at least not technically (proof: it works without any issue)
Did you try submitting on doctrine?
There was a problem hiding this comment.
Ok, I will revert this change and create pull-request to Doctrine. Will it ok?
There was a problem hiding this comment.
Reverted this renaming.
It's related to case sensitive.
This reverts commit dad846b.
|
Thank you @zomberg. |
This PR was squashed before being merged into the 2.7 branch (closes #19405). Discussion ---------- Fixed bugs in names of classes and methods. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ It's related to case sensitive. I changed only calls of names of called methods but not definition of methods because BC. Commits ------- c41aa03 Fixed bugs in names of classes and methods.
It's related to case sensitive.
I changed only calls of names of called methods but not definition of methods because BC.