[Console] Overcomplete argument exception message tweak. #19446
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't it target master instead of 2.7? |
|
why is that, it is not a BC? |
|
It might if some code rely on the message (very unlikely but you have the case with the tests), let's wait for fabpot pov anyway :) |
|
We can change an exception message, which is not part of the BC promise. Nobody should ever rely on an exception message in code anyway. |
|
Ok then big 👍 :) |
| throw new \RuntimeException(sprintf('Too many arguments, expected arguments "%s".', implode(', ', array_keys($all)))); | ||
| } | ||
|
|
||
| throw new \RuntimeException(sprintf('No argument expected, got "%s".', $token)); |
| @@ -183,7 +183,17 @@ public function provideInvalidInput() | |||
| array( | |||
| array('cli.php', 'foo', 'bar'), | |||
| new InputDefinition(), | |||
| 'Too many arguments.', | |||
| 'No argument expected got "foo".', | |||
There was a problem hiding this comment.
and a comma after "expected"
|
Thank you @SpacePossum. |
fabpot
added a commit
that referenced
this pull request
Jul 28, 2016
… (SpacePossum) This PR was squashed before being merged into the 2.7 branch (closes #19446). Discussion ---------- [Console] Overcomplete argument exception message tweak. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Updates the exception message when to many arguments are passed. From; ```php 'Too many arguments.' ``` To: ```php 'No argument expected, got "foo".' // or 'Too many arguments, expected arguments "foo".' // or 'Too many arguments, expected arguments "foo, bar".' // ... turtles all the way down ``` Commits ------- 7af59cd [Console] Overcomplete argument exception message tweak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the exception message when to many arguments are passed.
From;
'Too many arguments.'To: