[master][console] Allow multiple options to be set. #19495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything not related to this new feature should be removed as it would make merging old branches more difficult (and they don't bring any value anyway). |
|
|
||
| /** | ||
| * @group legacy | ||
| * @dataProvider provideInlineStyleTagsWithUnknownOptions |
There was a problem hiding this comment.
missing @requires function Symfony\Bridge\PhpUnit\ErrorAssert::assertDeprecationsAreTriggered annotation
There was a problem hiding this comment.
done,
just for my understanding, why is this needed?
There was a problem hiding this comment.
@SpacePossum when tests run in max depth (latest versions of the components supported for an older package) this function might not be available from the bridge.
There was a problem hiding this comment.
make sense, thanks for the info @HeahDude !
11649ef to
243d6fc
Compare
4cee435 to
1430138
Compare
|
rebased and all comments addressed |
|
Thank you @SpacePossum. |
fabpot
added a commit
that referenced
this pull request
Sep 14, 2016
…pacePossum)
This PR was merged into the 3.2-dev branch.
Discussion
----------
[master][console] Allow multiple options to be set.
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| License | MIT
This PR add the possibility to set multiple options on a formatted string output.
Example:
```php
$output->writeln('<fg=green;options=bold,underscore>Test</>');
```
Secondly it makes the behavior on invalid values consistent.
```php
// current
$output->writeln('<fg=lime;>Test</>'); // throws exception
$output->writeln('<options=italic;>Test</>'); // silent ignore
// new
$output->writeln('<fg=lime;>Test</>'); // throws exception
$output->writeln('<options=italic;>Test</>'); // throws exception
```
All other changes are about making the code more strict or other SCA/CS fixes.
Commits
-------
1430138 Allow multiple options to be set.
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 21, 2016
…SpacePossum) This PR was merged into the master branch. Discussion ---------- [Console] Add multiple options for the output example With symfony/symfony#19495 merged to master a way to set multiple options has been added. Commits ------- c6b4738 Update coloring.rst
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the possibility to set multiple options on a formatted string output.
Example:
Secondly it makes the behavior on invalid values consistent.
All other changes are about making the code more strict or other SCA/CS fixes.