[Process] Fix double-fread() when reading unix pipes #19510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2016
…las-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Process] Fix double-fread() when reading unix pipes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - While looking at the blackfire profile of a `composer install`, I was able to reduce the number of calls to `fread` from 90k to 60k using this patch (and from 60k to <1k with composer/composer#5569 but that's another story). In fact, we should continue reading only if there might be something next, which won"t be the case if the buffer has not been filled. Commits ------- ac17617 [Process] Fix double-fread() when reading unix pipes
This was referenced Sep 2, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the blackfire profile of a
composer install, I was able to reduce the number of calls tofreadfrom 90k to 60k using this patch (and from 60k to <1k with composer/composer#5569 but that's another story).In fact, we should continue reading only if there might be something next, which won't be the case if the buffer has not been filled.