[VarDumper] Relax 1 test failing with latest PHP versions #19539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,10 +94,8 @@ public function testCastFileObject() | |||
| file: true | |||
| dir: false | |||
| link: false | |||
| %AcsvControl: array:2 [ | |||
| 0 => "," | |||
| 1 => """ | |||
There was a problem hiding this comment.
can't we keep these two first lines and add %A for the third one?
There was a problem hiding this comment.
sure ;)
But does it really worth it ?.
Related to php bug symfony#52646 which is fixed in 5.6.25RC1, 7.0.10RC1, 7.1.0beta2
f6e1019 to
6703b41
Compare
|
@remicollet can you remove the first commit please? |
|
Sorry, I don't know how.... :( |
|
Thank you @remicollet. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 5, 2016
…s (fabpot, remicollet) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Relax 1 test failing with latest PHP versions | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | o | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | reference to the documentation PR, if any Related to php bug https://bugs.php.net/72646 which is fixed in 5.6.25RC1, 7.0.10RC1, 7.1.0beta2 Detected in Fedora CI, failed since 7.0.10RC1, see https://apps.fedoraproject.org/koschei/package/php-symfony Commits ------- 6703b41 Relax 1 test failing with latest PHP versions eabbcf0 bumped Symfony version to 2.8.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to php bug https://bugs.php.net/72646 which is fixed in 5.6.25RC1, 7.0.10RC1, 7.1.0beta2
Detected in Fedora CI, failed since 7.0.10RC1, see
https://apps.fedoraproject.org/koschei/package/php-symfony