Fix #19531 [Form] DateType fails parsing when midnight is not a valid time #19541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbeccati
commented
Aug 5, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19531 |
| License | MIT |
| Doc PR |
|
Thanks for fixing this so fast! Status: reviewed |
| */ | ||
| protected function isPatternDateOnly() | ||
| { | ||
| // the default pattern includes time |
There was a problem hiding this comment.
Maybe this comment is unnecessary?
|
@javiereguiluz Pushed comment amendments + additional test w/ escaped text |
| } | ||
|
|
||
| // strip escaped text | ||
| $pattern = preg_replace("#'(.*?)'#", '', $this->pattern); |
There was a problem hiding this comment.
Can you add a test with escaped ICU data?
There was a problem hiding this comment.
oh, it's there, I had to right scroll :)
|
👍 |
|
Thank you @mbeccati. |
fabpot
added a commit
that referenced
this pull request
Aug 13, 2016
…not a valid time (mbeccati) This PR was merged into the 2.7 branch. Discussion ---------- Fix #19531 [Form] DateType fails parsing when midnight is not a valid time | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19531 | License | MIT | Doc PR | Commits ------- c951bb6 Fix #19531 [Form] DateType fails parsing when midnight is not a valid time
This was referenced Sep 2, 2016
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Sep 8, 2016
…sformer (mbeccati) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Incorrect timezone with DateTimeLocalizedStringTransformer | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19721 | License | MIT | Doc PR | n.a. Issue was introduced in #19541 Commits ------- bf6691c Fix #19721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.