[HttpFoundation] Add named constructor on JsonResponse #19552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +59,14 @@ public static function create($data = null, $status = 200, $headers = array()) | |||
| } | |||
|
|
|||
| /** | |||
| * Make easier the creation of JsonResponse from raw json | |||
| */ | |||
| public static function fromJsonString($data = null, $status = 200, $headers = array()) | |||
There was a problem hiding this comment.
What about createFromStringcreateFromJsonString? or just createFromJson
There was a problem hiding this comment.
Btw createFromString somewhat implies a callback (JSONP) is parsed as well.. so you know ;-)
Edit: i guess we dont wanna go that way.
There was a problem hiding this comment.
No problem to switch to createFromJsonString. I'm used to remove the create prefix but if everyone prefer with it, I'm ok !
To make easier construction with raw json
4a14137 to
6d5a65d
Compare
|
👍 |
1 similar comment
|
👍 |
|
Thank you @tyx. |
fabpot
added a commit
that referenced
this pull request
Aug 16, 2016
… (tyx) This PR was merged into the 3.2-dev branch. Discussion ---------- [HttpFoundation] Add named constructor on JsonResponse | Q | A | ------------- | --- | Branch? | "master" | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | To make easier construction with raw json. It is a simple addition but having something like : ```php return new JsonResponse($content, Response::HTTP_OK, [], true); ``` and ```php return new JsonResponse($content, Response::HTTP_OK, []); ``` is not very obvious to get the difference without going to read the JsonResponse constructor. Commits ------- 6d5a65d Add named constructor on JsonResponse
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make easier construction with raw json. It is a simple addition but having something like :
and
is not very obvious to get the difference without going to read the JsonResponse constructor.