Skip to content

[Workflow] Updated link to the documentation #19602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Aug 12, 2016

Q A
Branch? "master"
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

The link to the docs was broken because of the big documentation restructure a couple of weeks back.

@@ -4,7 +4,7 @@ Workflow Component
Resources
---------

* [Documentation](https://symfony.com/doc/current/components/workflow/introduction.html)
* [Documentation](http://symfony.com/doc/master/components/workflow.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing https?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that was not my intention. I just copied the link from the address bar.

I guess there was no http://symfony.com/ => https://symfony.com/ redirect.

@@ -4,7 +4,7 @@ Workflow Component
Resources
---------

* [Documentation](https://symfony.com/doc/current/components/workflow/introduction.html)
* [Documentation](https://symfony.com/doc/master/components/workflow.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and you need to keep current instead of master to be consistent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would lead to another 404 page until Symfony 3.2 is released. Is that what you want?

I suggest to keep "master" until 3.2 is released and then update this link again.

@fabpot
Copy link
Member

fabpot commented Aug 13, 2016

Thank you @Nyholm.

@fabpot fabpot closed this in 7022f8c Aug 13, 2016
@Nyholm
Copy link
Member Author

Nyholm commented Aug 13, 2016

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants