[VarDumper] Enhance dumping __PHP_Incomplete_Class objects #19630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
173dc19 to
90c715b
Compare
|
👍 |
492adb2 to
31190d3
Compare
31190d3 to
ee20d15
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 16, 2016
…ects (nicolas-grekas)
This PR was merged into the 3.2-dev branch.
Discussion
----------
[VarDumper] Enhance dumping __PHP_Incomplete_Class objects
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets | -
| License | MIT
| Doc PR | -
Before:
```
__PHP_Incomplete_Class {
+"__PHP_Incomplete_Class_Name": "Foo\Buzz"
}
```
after:
```
__PHP_Incomplete_Class(Foo\Buzz) {}
```
The new output is less confusing: no dynamic property exists on incomplete class objects, yet the `+` prefix suggests that.
Commits
-------
ee20d15 [VarDumper] Enhance dumping __PHP_Incomplete_Class objects
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
after:
The new output is less confusing: no dynamic property exists on incomplete class objects, yet the
+prefix suggests that.