[Finder] no PHP warning on empty directory iteration #19636
Conversation
ggottwald
commented
Aug 16, 2016
•
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR | Since RecursiveDirectoryIterator::SKIP_DOTS is set as flag, opendir gets a warning if an empty directory is reached |
| @@ -137,6 +137,10 @@ public function isRewindable() | |||
| return $this->rewindable; | |||
| } | |||
|
|
|||
| if ($this->getPath() === '') { | |||
| return $this->rewindable = false; | |||
| } | |||
There was a problem hiding this comment.
A test should probably be added to cover this scenario
|
@ggottwald Can you update the empty title to something relevant? Thanks. |
|
https://gist.github.com/ggottwald/07194dc7926ae9093b773ec2297116f3 |
|
@ggottwald could you please add a test case? |
|
Sorry for the late response. Until now I was not able to force a catchable warning in the test. |
|
👍 |
| @@ -137,6 +137,10 @@ public function isRewindable() | |||
| return $this->rewindable; | |||
| } | |||
|
|
|||
| if ($this->getPath() === '') { | |||
There was a problem hiding this comment.
should be using a Yoda condition: '' === $this->getPath()
|
Thank you @ggottwald. |
…twald) This PR was squashed before being merged into the 2.7 branch (closes #19636). Discussion ---------- [Finder] no PHP warning on empty directory iteration | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Since RecursiveDirectoryIterator::SKIP_DOTS is set as flag, opendir gets a warning if an empty directory is reached Commits ------- 695e341 [Finder] no PHP warning on empty directory iteration