[FrameworkBundle][Debug] Fix default config and cleaning of traces #19656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34817a4 to
99230ab
Compare
|
👍 |
| ->defaultValue(false) | ||
| ->treatNullLike(false) | ||
| ->defaultValue($this->debug) | ||
| ->treatNullLike($this->debug) |
There was a problem hiding this comment.
That still does not make sense for me :) Looks like you are not fixing the root cause here.
There was a problem hiding this comment.
This config is just how things work since 2.7 at least (and before I guess): in debug mode, we log deprecations and silenced errors to show them in the profiler. In prod (aka !debug), the current strategy is to let the native PHP error handler to deal with any error. This was hidden hard coded in the DI extension and is now exposed to users. There is no change here from what's done since years...
99230ab to
f640870
Compare
|
Big 👍, this is currently a BC break. |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 22, 2016
… of traces (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle][Debug] Fix default config and cleaning of traces | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | Tests pass? | yes | Fixed tickets | Follow up #19568 | License | MIT | Doc PR | - The default value of `framework.php_errors.log` must be `%kernel.debug%` to have deprecations and silenced errors logged in dev as before. Cleaning the trace was broken because a closure can't be bound to an internal class. This PR fixes both issues and enhance trace cleaning a bit by removing arguments from traces so that they take less memory when collected as part of the context of log messages. Commits ------- f640870 [FrameworkBundle][Debug] Fix default config and cleaning of traces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of
framework.php_errors.logmust be%kernel.debug%to have deprecations and silenced errors logged in dev as before.Cleaning the trace was broken because a closure can't be bound to an internal class.
This PR fixes both issues and enhance trace cleaning a bit by removing arguments from traces so that they take less memory when collected as part of the context of log messages.