Skip to content

[VarDumper] Add line in trace indexes #19657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2016

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? master
New feature? yes
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Allows seeing the line number when the frames are collapsed, e.g.:
capture du 2016-08-18 13-48-27

@fabpot
Copy link
Member

fabpot commented Aug 18, 2016

I think a common "convention" is file:line instead of file +line.

@nicolas-grekas
Copy link
Member Author

updated

@fabpot
Copy link
Member

fabpot commented Aug 18, 2016

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 0b13016 into symfony:master Aug 18, 2016
fabpot added a commit that referenced this pull request Aug 18, 2016
This PR was merged into the 3.2-dev branch.

Discussion
----------

[VarDumper] Add line in trace indexes

| Q             | A
| ------------- | ---
| Branch?       | master
| New feature?  | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Allows seeing the line number when the frames are collapsed, e.g.:
![capture du 2016-08-18 13-48-27](https://cloud.githubusercontent.com/assets/243674/17772691/872c6bd0-654a-11e6-9886-95fe57baca61.png)

Commits
-------

0b13016 [VarDumper] Add line in trace indexes
@nicolas-grekas nicolas-grekas deleted the vardump-tweak branch August 18, 2016 15:51
@fabpot fabpot mentioned this pull request Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants