Disable CLI color for Windows 10 greater than 10.0.10586 #19660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -85,7 +85,7 @@ protected function doWrite($message, $newline) | |||
| * | |||
| * Colorization is disabled if not supported by the stream: | |||
| * | |||
| * - Windows before 10.0.10586 without Ansicon, ConEmu or Mintty | |||
| * - Windows not 10.0.10586 without Ansicon, ConEmu or Mintty | |||
There was a problem hiding this comment.
what about: Windows != 10.0.10586 without Ansicon, ConEmu nor Mintty
There was a problem hiding this comment.
Well, for me != and not are synonymous...
There was a problem hiding this comment.
for me != means "different than", which reads better imho than "not"
There was a problem hiding this comment.
Since for you it's so relevant, I updated this PR 😉
|
👍 |
|
Thank you @mlocati. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 19, 2016
…mlocati) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #19660). Discussion ---------- Disable CLI color for Windows 10 greater than 10.0.10586 | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19520 | License | MIT | Doc PR | The command prompt in Windows 10.0.10586 had enabled color support by default. But in the next Windows versions they disabled it ([reference](https://wpdev.uservoice.com/forums/266908-command-prompt-console-bash-on-ubuntu-on-windo/suggestions/15617610--re-enable-enable-virtual-terminal-processing-by)): every exe now needs to explicitly turn on the color support. I [already asked](https://bugs.php.net/bug.php?id=72768) the PHP dev team to enable it for php.exe, but they said they are busy for now. So, let's turn off colors for Windows, until we'll have new PHP versions with color support enabled. Commits ------- 255c59f Disable CLI color for Windows 10 greater than 10.0.10586
This was referenced Sep 2, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command prompt in Windows 10.0.10586 had enabled color support by default.
But in the next Windows versions they disabled it (reference): every exe now needs to explicitly turn on the color support.
I already asked the PHP dev team to enable it for php.exe, but they said they are busy for now.
So, let's turn off colors for Windows, until we'll have new PHP versions with color support enabled.