Skip to content

[HttpKernel] Fix too strict test #19674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Aug 19, 2016

Q A
Branch? 2.7
Tests pass? yes
License MIT

This test is too strict and prevents adding properties to Data objects for no reason.

@stof
Copy link
Member

stof commented Aug 19, 2016

👍

@nicolas-grekas nicolas-grekas merged commit 2e7301d into symfony:2.7 Aug 19, 2016
nicolas-grekas added a commit that referenced this pull request Aug 19, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[HttpKernel] Fix too strict test

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Tests pass?   | yes
| License       | MIT

This test is too strict and prevents adding properties to Data objects for no reason.

Commits
-------

2e7301d [HttpKernel] Fix too strict test
@nicolas-grekas nicolas-grekas deleted the fix-test branch August 19, 2016 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants