[Debug][HttpKernel][VarDumper] Prepare for committed 7.2 changes (aka "small-bc-breaks") #19702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -263,7 +263,10 @@ private function flattenArgs($args, $level = 0, &$count = 0) | |||
| if (++$count > 1e4) { | |||
| return array('array', '*SKIPPED over 10000 entries*'); | |||
| } | |||
| if (is_object($value)) { | |||
| if ($value instanceof \__PHP_Incomplete_Class) { | |||
| // Special case of object, is_object will return false | |||
There was a problem hiding this comment.
you should update the comment, as it will be a lie on PHP 7.2 currently
| @@ -263,7 +263,10 @@ private function flattenArgs($args, $level = 0, &$count = 0) | |||
| if (++$count > 1e4) { | |||
| return array('array', '*SKIPPED over 10000 entries*'); | |||
| } | |||
| if (is_object($value)) { | |||
| if ($value instanceof \__PHP_Incomplete_Class) { | |||
| // Special case of object, is_object will return false until PHP 7.1 | |||
There was a problem hiding this comment.
is_object returns false until PHP 7.1?
nicolas-grekas
added a commit
that referenced
this pull request
Aug 23, 2016
…hanges (aka "small-bc-breaks") (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Debug][HttpKernel][VarDumper] Prepare for committed 7.2 changes (aka "small-bc-breaks") | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | Tests pass? | yes | License | MIT On PHP 7.2: - `is_object()` is going to return `true` for `__PHP_Incomplete_Class` instances - `gettype($closed_resource);` returns "resource (closed)" ping @nikic FYI see https://travis-ci.org/symfony/symfony/jobs/154114269 for fixed tests (except the one on ClassLoader which is a BC break on 7.1 that should be fixed there IMHO). Commits ------- feb2cd0 [Debug][HttpKernel][VarDumper] Prepare for committed 7.2 changes
This was referenced Sep 2, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On PHP 7.2:
is_object()is going to returntruefor__PHP_Incomplete_Classinstancesgettype($closed_resource);returns "resource (closed)"ping @nikic FYI
see https://travis-ci.org/symfony/symfony/jobs/154114269 for fixed tests (except the one on ClassLoader which is a BC break on 7.1 that should be fixed there IMHO).