[VarDumper] Handle "title" attribute on virtual properties #19714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c5d4f0 to
b51fb66
Compare
b51fb66 to
19bcf63
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 23, 2016
…ties (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [VarDumper] Handle "title" attribute on virtual properties | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | License | MIT As seen with @wouterj , it would be better to *not* display the stack level in front of each stack line. This PR does just that, and moves the stack level to a title attribute in HtmlDumper.  Commits ------- 19bcf63 [VarDumper] Handle "title" attribute on virtual properties
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen with @wouterj , it would be better to not display the stack level in front of each stack line.
This PR does just that, and moves the stack level to a title attribute in HtmlDumper.