Skip to content

[FrameworkBundle][Security] Remove useless mocks #19736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2016
Merged

Conversation

GuilhemN
Copy link
Contributor

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Removes mocks causing issues in #19734.

@nicolas-grekas
Copy link
Member

👍
Status: reviewed

@fabpot
Copy link
Member

fabpot commented Aug 25, 2016

Thank you @Ener-Getick.

@fabpot fabpot merged commit fcd3345 into symfony:2.7 Aug 25, 2016
fabpot added a commit that referenced this pull request Aug 25, 2016
…etick)

This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle][Security] Remove useless mocks

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Removes mocks causing issues in #19734.

Commits
-------

fcd3345 [FrameworkBundle][Security] Remove useless mocks
@GuilhemN GuilhemN deleted the MOCK branch August 25, 2016 17:54
@GuilhemN
Copy link
Contributor Author

@fabpot Thanks to you !

BTW shouldn't your tool merging PRs use a more generic reference such as symfony/symfony#19736 ?
Because references are broken in commits title of sub repositories.

@fabpot
Copy link
Member

fabpot commented Aug 25, 2016

That's a good remark. But I'm afraid that adding symfony/symfony in front would make the message way less readable :(

@GuilhemN
Copy link
Contributor Author

GuilhemN commented Aug 25, 2016

@fabpot if i'm not wrong github is smart enough to hide it when that's not necessary (in the main repo).

Edit: i think that's worth it, i often want to read comments corresponding to a change and having a link is a time saver :)

@fabpot
Copy link
Member

fabpot commented Aug 25, 2016

probably, but I was more talking about git in general, like when doing git log, ...

@GuilhemN
Copy link
Contributor Author

That's a good argument :/
maybe you could update references in splitter to make them longer only in sub repos ? Otherwise that's still just a small detail, convenient but it shouldn't make other things harder of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants