[Validator] Added context object method callback to choice validator #19745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouwdie
commented
Aug 26, 2016
| Q | A |
|---|---|
| Branch? | "master" |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
dc39bc9 to
c62d94c
Compare
|
Could the build please be restarted? I squashed a commit on the fork branch. |
|
@Bouwdie the build is triggered automatically on push. I restarted it nevertheless. The failure is legitimate (it's introduced by this PR). |
|
@jakzal thx for restarting them anyway! I should have taken the behaviour of is_callable into account. |
…validator to prevent invoking non-static methods
|
@jakzal Everything is working correctly and the build succeeds. Is there anything more i can do to speed the review process? |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @Bouwdie. |
|
Documenting this feature here: symfony/symfony-docs#6973 |
|
@ro0NL Thank you for noticing this pull request 👍 |
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 21, 2016
This PR was squashed before being merged into the master branch (closes #6973). Discussion ---------- Callback doesn't have to be static Adding documentation for symfony/symfony#19745 Commits ------- 79bc283 Callback doesn't have to be static
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.