Fixes the calendar in constructor to handle null #19751
Conversation
|
Test Details: BEFORE Testing Symfony\Component\Intl\Tests\DateFormatter\IntlDateFormatterTest Time: 49 ms, Memory: 4.50MB There was 1 error:
/Users/waqasahmed/Desktop/symfony-2.7/src/Symfony/Component/Intl/DateFormatter/IntlDateFormatter.php:153 FAILURES! AFTER $ php ./phpunit --filter testConstructorWithoutCalendar IntlDateFormatterTest src/Symfony/Component/Intl/Tests/DateFormatter/IntlDateFormatterTest.php Testing Symfony\Component\Intl\Tests\DateFormatter\IntlDateFormatterTest Time: 45 ms, Memory: 4.25MB OK (1 test, 1 assertion) |
|
LGTM 👍 as it's in line with http://php.net/manual/en/intldateformatter.create.php |
|
👍 Status: reviewed |
|
Thank you @wakqasahmed. |
…med) This PR was merged into the 2.7 branch. Discussion ---------- Fixes the calendar in constructor to handle null | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19688 | License | MIT | Doc PR | none Fix the calendar exception to handle null, error was raised while exporting from akeneo The Symfony\Component\Intl\DateFormatter\IntlDateFormatter::__construct() method's argument $calendar value NULL behavior is not implemented. Only the GREGORIAN calendar is supported. Please install the "intl" extension for full localization capabilities. https://cloud.githubusercontent.com/assets/4486133/17287404/81f951cc-57e0-11e6-9f6f-e231bbf00bf4.png Commits ------- 43f2672 Fixes the calendar in constructor to handle null
Fix the calendar exception to handle null, error was raised while exporting from akeneo
The Symfony\Component\Intl\DateFormatter\IntlDateFormatter::__construct() method's argument $calendar value NULL behavior is not implemented. Only the GREGORIAN calendar is supported. Please install the "intl" extension for full localization capabilities.
https://cloud.githubusercontent.com/assets/4486133/17287404/81f951cc-57e0-11e6-9f6f-e231bbf00bf4.png