Update profiler's layout to use flexbox #19786
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiereguiluz Well, the flexbox is a tricky one but the thing you have to do is to add |
|
@eXtreme your proposal solved the problem brilliantly! Thanks. So this is now ready to be reviewed and merge/reject it. |
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Aug 31, 2016
This PR was squashed before being merged into the 2.8 branch (closes #19786). Discussion ---------- Update profiler's layout to use flexbox | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - ### Problem The layout of the profiler uses some old CSS tricks to make the sidebar look like a same-height sidebar (`margin-bottom: -99999px;` and `padding-bottom: 99999px;`, a large `min-height` in the content, etc.) This works most of the time ... but there are some edge cases where the sidebar looks ugly (it doesn't have the same height as the main content). ### Solution This proposal updates the profiler layout to use CSS flexbox. * It looks and behaves exactly like before ... but it also fixes all the edge cases. * flexbox has ~90% of global browser support --> so it should be 100% of Symfony developers --- ~~Sadly **there is one issue that I cannot solve**:~~ ~~* The "Performance" panel doesn't work on Chrome and Firefox (but it works on Safari!!)~~ ~~* The problem is that the `getContainerWidth()` function in `time.html.twig` template doesn't return the right value and the generated canvas has a wrong width.~~ ~~Any clues?~~ It's fixed now! Commits ------- d986ac0 Update profiler's layout to use flexbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The layout of the profiler uses some old CSS tricks to make the sidebar look like a same-height sidebar (
margin-bottom: -99999px;andpadding-bottom: 99999px;, a largemin-heightin the content, etc.)This works most of the time ... but there are some edge cases where the sidebar looks ugly (it doesn't have the same height as the main content).
Solution
This proposal updates the profiler layout to use CSS flexbox.
Sadly there is one issue that I cannot solve:* The "Performance" panel doesn't work on Chrome and Firefox (but it works on Safari!!)* The problem is that thegetContainerWidth()function intime.html.twigtemplate doesn't return the right value and the generated canvas has a wrong width.Any clues?It's fixed now!