[WebProfilerBundle] Fix infinite loop in JS #19803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var toolbarBlocks = document.querySelectorAll('.sf-toolbar-block'); | ||
| for (var i = 0; i < toolbarBlocks.length; i += 1) { | ||
| var toolbarBlocks = [].slice.call(document.querySelectorAll('.sf-toolbar-block')); | ||
| for (i in toolbarBlocks) { |
There was a problem hiding this comment.
I would leave the iteration with incrementor i. On some browsers it can iterate on some unexpected properties inherited from prototype
eaa0c09 to
68b6c32
Compare
|
👍 LGTM |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 1, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [WebProfilerBundle] Fix infinite loop in JS | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes (master only) | Tests pass? | yes | License | MIT For some reason, I ended up having this while loop infinitely. Commits ------- 68b6c32 [WebProfilerBundle] Fix infinite loop in JS
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…s-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [WebProfilerBundle] Fix infinite loop in JS | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes (master only) | Tests pass? | yes | License | MIT For some reason, I ended up having this while loop infinitely. Commits ------- 68b6c32 [WebProfilerBundle] Fix infinite loop in JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, I ended up having this while loop infinitely.