[VarDumper] Add ClassStub for clickable & shorter PHP identifiers #19826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f53a482 to
0d0b08b
Compare
0d0b08b to
788f7e8
Compare
| class ClassStub extends ConstStub | ||
| { | ||
| /** | ||
| * Constructor. |
There was a problem hiding this comment.
We're not doing that anymore, right?
There was a problem hiding this comment.
The docbloc needs a title...
And I'd think it's worth document the arguments a bit...
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 2, 2016
…identifiers (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [VarDumper] Add ClassStub for clickable & shorter PHP identifiers | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | yes | License | MIT | Doc PR | symfony/symfony-docs#6946 Tells dumpers when PHP identifiers are used so that they can shorten the namespace and create IDE links to the source.  (PR also embeds some fixes/cleanups) Commits ------- 788f7e8 [VarDumper] Add ClassStub for clickable & shorter PHP identifiers
|
@nicolas-grekas how can I enable the shorten feature? I always get the FQNC without |
|
Are you sure to be on latest master? Can you try with a different browser just in case it's a CSS support issue? When looking at the source code, can you see the |
|
I was on latest master, but the extracted data appeared not to. It works as expected now. |
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tells dumpers when PHP identifiers are used so that they can shorten the namespace and create IDE links to the source.
(PR also embeds some fixes/cleanups)