[2.1] added a Controller:getUser() shortcut to recover the current user #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function getUser() | ||
| { | ||
| if (!$this->container->has('security.context')) { | ||
| throw new \LogicException('The SecurityBundle is not installed in your application.'); |
There was a problem hiding this comment.
I don't want to be pedantic, but i would like to suggest to use the term "registered" instead of "installed", as it is the common sf2 terminology.
@fabpot Btw, long time ago there was a discussion about more pedagogy in error messages in the dev group: https://groups.google.com/group/symfony-devs/browse_thread/thread/f8045eab3a780e25/9c1af84f3d9ffac2
Has this been established finally?
There was a problem hiding this comment.
@kaiwa: we try to improve error messages on case by case basis.
fabpot
added a commit
that referenced
this pull request
Sep 28, 2011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.