[Bridge/PhpUnit] Add bin/simple-phpunit wrapper (=phpunit - yaml - prophecy) #19915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b9fa27a to
37c18f1
Compare
| @@ -34,7 +34,7 @@ matrix: | |||
|
|
|||
| cache: | |||
| directories: | |||
| - .phpunit | |||
| - vendor/symfony/phpunit-bridge/bin/.phpunit | |||
There was a problem hiding this comment.
Isn't it an "issue" that we write in the vendor directory? I'm pretty sure that we never write under vendor anywhere else.
There was a problem hiding this comment.
updated: this is still the default because I don't see any better one, but one can overwrite it with the SYMFONY_PHPUNIT_DIR env var now.
17e81a1 to
966a55d
Compare
|
I think we need to add some docs to the README about its usage and the env vars that one can define. |
|
Doc PR added, tests green. |
966a55d to
0c1c70c
Compare
|
Needs #19917 to be green (and reciprocally) |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 12, 2016
…nit - yaml - prophecy) (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [Bridge/PhpUnit] Add bin/simple-phpunit wrapper (=phpunit - yaml - prophecy) | Q | A | ------------- | --- | Branch? | master | New feature? | yes | Tests pass? | not yet | License | MIT | Doc PR | symfony/symfony-docs#6962 So that e.g. [Sami](https://github.com/FriendsOfPHP/Sami/blob/master/phpunit) & [SensioFranmeworkExtraBundle](https://github.com/sensiolabs/SensioFrameworkExtraBundle/blob/master/phpunit) can stop copy/pasting our phpunit wrapper and get it from phpunit-bridge instead. 2 commits to keep the "rename" semantic in the git history. Diff best viewed by looking directly at each commit. Commits ------- 0c1c70c [Bridge/PhpUnit] Add bin/simple-phpunit wrapper (=phpunit - yaml - prophecy)
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 15, 2016
…, weaverryan) This PR was merged into the master branch. Discussion ---------- [Bridge/PhpUnit] doc bin/simple-phpunit See symfony/symfony#19915 Commits ------- c600921 Making changes thanks to Javier! 46825ab [Bridge/PhpUnit] doc bin/simple-phpunit
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that e.g. Sami & SensioFranmeworkExtraBundle can stop copy/pasting our phpunit wrapper and get it from phpunit-bridge instead.
2 commits to keep the "rename" semantic in the git history.
Diff best viewed by looking directly at each commit.