[bugfix] [Console] Set Input::$interactive to false when command is executed with --quiet as verbosity level
#19923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is executed with `--quiet` as verbosity level
|
I don't understand why quiet and interactive would be tied. I made this decoupling consciously back then. It looks more flexible. So, I'm 👎 for this change. |
|
I understand your concern about the responsibilities, but the fact I'm exposing here is that isn't possible to interact with a command when it is executed in quiet mode, given the command isn't able to prompt for any input or provide any kind of response to the user. For this reason, I think a method called |
|
Ah, understood now. Indeed, if even the questions are not displayed, that does not really make sense to have an interactive quiet command :) |
|
Thank you @phansys. |
fabpot
added a commit
that referenced
this pull request
Sep 14, 2016
…en command is executed with `--quiet` as verbosity level (phansys) This PR was merged into the 2.7 branch. Discussion ---------- [bugfix] [Console] Set `Input::$interactive` to `false` when command is executed with `--quiet` as verbosity level |Q |A | |--- |--- | |Branch |2.7 | |Bug fix? |yes | |New feature? |no | |BC breaks? |yes | |Deprecations?|no | |Tests pass? |yes | |Fixed tickets|#19899| |License |MIT | |Doc PR |n/a | Closes #19899. Commits ------- 4214311 [bugfix] [Console] Set `Input::$interactive` to `false` when command is executed with `--quiet` as verbosity level
This was referenced Oct 3, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19899.