[DoctrineBridge][PropertyInfo] Treat Doctrine decimal type as string #19924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status: reviewed |
76ed973 to
62d28f9
Compare
|
@teohhanhui just asking: could this be a BC break for some application? |
|
I'd see it as a bug, i.e. we were returning the wrong type. But of course, yes, applications might break if they depend on a certain type being returned. (I don't think that should be considered part of our BC promise.) |
|
Thank you @teohhanhui. |
fabpot
added a commit
that referenced
this pull request
Sep 13, 2016
… as string (teohhanhui) This PR was merged into the 2.8 branch. Discussion ---------- [DoctrineBridge][PropertyInfo] Treat Doctrine decimal type as string | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Using `float` for decimal type defeats the purpose of avoiding rounding errors / loss of precision. See http://docs.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/types.html#decimal Commits ------- 62d28f9 [DoctrineBridge][PropertyInfo] Treat Doctrine decimal type as string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
floatfor decimal type defeats the purpose of avoiding rounding errors / loss of precision.See http://docs.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/types.html#decimal