[TwigBridge] Added access to token from twig AppVariable #19991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,13 +72,7 @@ public function setDebug($debug) | |||
| */ | |||
| public function getUser() | |||
| { | |||
| if (null !== $this->tokenStorage) { | |||
There was a problem hiding this comment.
not sure this change is needed, and it forces the error message to be less specific
There was a problem hiding this comment.
It's moved to the getToken() method.
There was a problem hiding this comment.
Ah, I see what you mean now. Indeed the message will not be specific to the user anymore (will be about token). I'd indeed keep the check and throw an exception like before.
0604d54 to
a56a108
Compare
a56a108 to
efd3e2d
Compare
|
Comments addressed. |
|
Thank you @HeahDude. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2016
…le (HeahDude) This PR was merged into the 3.2-dev branch. Discussion ---------- [TwigBridge] Added access to token from twig AppVariable | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | TODO In Symfony 2.x we could access the token from `app.security` but now we can only get the user even if it comes from the token storage. This makes mandatory to create a custom twig extension to access it and thus harder to update to symfony 3.x when you need this simple getter in a template where custom tokens are involved (e.g using a ConnectToken from SensioLabs Connect API). I hope this little feature will be part of 3.2 :) Commits ------- efd3e2d Added access to token from twig AppVariable
Merged
fabpot
added a commit
that referenced
this pull request
Dec 13, 2016
…eahDude) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Added GlobalVariables::getToken() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony-docs#7191 comments | License | MIT | Doc PR | symfony/symfony-docs#7191 I propose this feature as bug fix in 3.2, since I don't use the PHP templating I forgot to add the method in the `FrameworkBundle`, to keep it align with the `TwigBridge` in #19991. Is this acceptable or should it go in master? Commits ------- 099b848 Added GlobalVariables::getToken()
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Dec 13, 2016
…eahDude) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Added GlobalVariables::getToken() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony-docs#7191 comments | License | MIT | Doc PR | symfony/symfony-docs#7191 I propose this feature as bug fix in 3.2, since I don't use the PHP templating I forgot to add the method in the `FrameworkBundle`, to keep it align with the `TwigBridge` in symfony/symfony#19991. Is this acceptable or should it go in master? Commits ------- 099b848 Added GlobalVariables::getToken()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony 2.x we could access the token from
app.securitybut now we can only get the user even if it comes from the token storage.This makes mandatory to create a custom twig extension to access it and thus harder to update to symfony 3.x when you need this simple getter in a template where custom tokens are involved (e.g using a ConnectToken from SensioLabs Connect API).
I hope this little feature will be part of 3.2 :)