[Routing] Fixed route generation with fragment defined as defaults #20001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b79dabb to
9d445a0
Compare
jakzal
reviewed
Sep 21, 2016
| $fragment = $defaults['_fragment']; | ||
| } | ||
|
|
||
| if (array_key_exists('_fragment', $extra)) { |
There was a problem hiding this comment.
You changed behaviour here for the case when _fragment is null. isset() will return false, while array_key_exists() will return true for a key with null value.
9d445a0 to
40d9306
Compare
|
@jakzal reverted original behaviour. |
xabbuh
reviewed
Sep 21, 2016
| public function testFragmentsCanBeDefinedAsDefaults() | ||
| { | ||
| $routes = $this->getRoutes('test', new Route('/testing', array('_fragment' => 'fragment'))); | ||
| $url = $this->getGenerator($routes)->generate('test', array(), true); |
There was a problem hiding this comment.
The third argument must not be a boolean. Please pass UrlGeneratorInterface::ABSOLUTE_PATH here (see #20009 which fixes the other tests).
40d9306 to
3c36596
Compare
|
👍 Status: Reviewed |
|
Thank you @akovalyov. |
fabpot
added a commit
that referenced
this pull request
Sep 21, 2016
…defaults (akovalyov) This PR was merged into the 3.2-dev branch. Discussion ---------- [Routing] Fixed route generation with fragment defined as defaults | Q | A | ------------- | --- | Branch? | "master" | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT As stated in https://symfony.com/blog/new-in-symfony-3-2-routing-improvements, it should support `_fragment` option as part of `_defaults` of route definition. Commits ------- 3c36596 [Routing] Fixed route generation with fragment defined as defaults
|
@fabpot my pleasure! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in https://symfony.com/blog/new-in-symfony-3-2-routing-improvements, it should support
_fragmentoption as part of_defaultsof route definition.